Review Request 126417: don't rely on char* to QString implicit conversion
Martin Gräßlin
mgraesslin at kde.org
Fri Dec 18 15:02:21 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126417/#review89717
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Gräßlin
On Dec. 18, 2015, 3:20 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126417/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 3:20 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> my Qt won't cast char* to QString, so explicitly use QStringLiteral here.
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.cpp 614b793fa724e7be0fb2dd8151374303fcc6ec18
>
> Diff: https://git.reviewboard.kde.org/r/126417/diff/
>
>
> Testing
> -------
>
> Windows.
>
>
> Thanks,
>
> Patrick Spendrin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151218/45e10ab5/attachment.html>
More information about the Plasma-devel
mailing list