Review Request 126380: Fix OutputDevice::edid()

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126380/#review89579
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Gräßlin


On Dec. 16, 2015, 2:38 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126380/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 2:38 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> This patch transports the EDID data base64-encoded over the wire.
> 
> Apparently, we can't just send random QByteArrays as "strings" over, it has to be encoded and decoded. So...
> 
> - base64-encode the data before sending to the client
> - base64-decode it on the client side
> - document the above, fix documentation woes in the xml definition
> - change test accordingly
> 
> The test data used was actually invalid, it's a base64 string of the actual data, so fix the tests (which actually breaks it), and encode on the server-side and decode on the client side.
> 
> I'm not sure if base64 is the best way to go here, suggestions welcome.
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_outputdevice.cpp beefc45 
>   src/client/outputdevice.cpp bfde34f 
>   src/client/protocols/outputdevice.xml e790fdd 
>   src/server/outputdevice_interface.cpp adf65a1 
> 
> Diff: https://git.reviewboard.kde.org/r/126380/diff/
> 
> 
> Testing
> -------
> 
> broke test by decoding the string from base64, fixed code, tests pass again.
> 
> Also, it works in the libkscreen kwayland backend now.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151216/9aeb307d/attachment.html>