Review Request 126356: change minimum size of clipboard

Martin Gräßlin mgraesslin at kde.org
Tue Dec 15 14:29:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/#review89547
-----------------------------------------------------------



applets/clipboard/contents/ui/clipboard.qml (line 69)
<https://git.reviewboard.kde.org/r/126356/#comment61276>

    this is not the actual size of the systray, but a hardcoded value which might match (or not) the size of systray.
    
    As the motivation sounds correct to me I suggest to find a way to actually use the size of systray. Experts around?


- Martin Gräßlin


On Dec. 15, 2015, 1:37 p.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126356/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 1:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> if you use clipboard on the desktop the minimum window height is heigher than you use clipboard from the panel (drop down window). As the user can define the width and height for the desktop plasmoid the minimum allowed height should be at least the same than the drop down window in the panel. so I change the minimumHeig to 16.
> 
> 
> Diffs
> -----
> 
>   applets/clipboard/contents/ui/clipboard.qml 97230c1 
> 
> Diff: https://git.reviewboard.kde.org/r/126356/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> old before with 26 min height
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
> new after with 16 min height
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151215/2ebd2424/attachment-0001.html>


More information about the Plasma-devel mailing list