Review Request 126363: Use gridUnit for default panel thickness

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126363/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 2:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit eed2f0206184a5066038a6dea7402f24634fb72e by Eike Hein to branch Plasma/5.5.


Repository: plasma-desktop


Description
-------

This makes the initial panel thickness scale.

I've removed the calculation taking screen res into account because res != physical size, and this is not actually working on my three systems (screenGeometry.height() is always 0), nor have I seen proportionally larger panels on screenshots. If it's not working it means nobody is used to getting a larger panel, nor have there been complaints, so we can drop this complexity. It also means we don't have to work in half-gridUnits to get close to the original value (if you assume the original delta was chosen on a 96 dpi system).


Diffs
-----

  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js 46b1f3b 

Diff: https://git.reviewboard.kde.org/r/126363/diff/


Testing
-------

Default panel thickness now comes out as 28px instead of 27px on a 96 dpi test system.


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151215/afd56eb3/attachment.html>