Review Request 126357: Workaround a system icon tray issue in bug 352055

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126357/#review89543
-----------------------------------------------------------


This isn't really a workaround, it's what the code was originally trying to be doing. 

The former is wrong as it actually starts a timer

- David Edmundson


On Dec. 15, 2015, 4:44 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126357/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 4:44 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 352055
>     https://bugs.kde.org/show_bug.cgi?id=352055
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> For whatever reason (probably inside Qt itself), this specific change can workaround one of causes of bug 352055 for people hitting disappeared icon in system tray.
> 
> For why this is different from the current implementation, see https://bugs.kde.org/show_bug.cgi?id=352055#c38
> 
> There seems to be two different bug in 352055 but looks similar, the other one is fixed in Qt 5.6 according to Albert Astals Cid.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/host.cpp 61e8705 
> 
> Diff: https://git.reviewboard.kde.org/r/126357/diff/
> 
> 
> Testing
> -------
> 
> At least fix my problem here locally.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151215/84d80b9c/attachment.html>