Review Request 126349: Add screenPixelRatio(int screen) to desktop scripting API

[Eike Hein]

> On Dec. 14, 2015, 6:36 p.m., David Edmundson wrote:
> > Lets put it in the same place as gridUnit which is currently in scriptengine.cpp
> > 
> > 
> > Whilst it's worth exporting this, is using gridUnit not the the most Plasma approach to solving the panel problem?

Possibly, but I don't want to rock the boat too much right now on changing these pixel values (because I don't know how they were picked) and I want to put this into the 5.5 branch as well.

Can you explain how you want this put into ScriptEngine? If it's a simple prop it can't have a screen parameter so it'll break when the screen becomes relevant later.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126349/#review89486
-----------------------------------------------------------


On Dec. 14, 2015, 6 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126349/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 6 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a global function qreal screenPixelRatio(int screen) to the desktop scripting API to complement screenGeometry(). Since we don't do per-screen scaling in Plasma currently the implementation ignores the argument. It's otherwise matching Units::devicePixelRatio.
> 
> If this becomes available, I can use it in the default panel layout script to scale the default panel thickness, which is currently unscaled - i.e. when Plasma scales up on a hi-dpi screen the panel will be initialized to be tiny anyway, which is a pretty egregrious papercut on hidpi systems.
> 
> 
> Diffs
> -----
> 
>   shell/scripting/appinterface.h 93aa014 
>   shell/scripting/appinterface.cpp 2c54f1e 
> 
> Diff: https://git.reviewboard.kde.org/r/126349/diff/
> 
> 
> Testing
> -------
> 
> Adjusted layout script, determined it works nicely.
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151214/1c811836/attachment.html>