Review Request 126333: [Keyboard KCM] Use getShortText for OSD as well

Martin Klapetek martin.klapetek at gmail.com
Mon Dec 14 14:32:44 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126333/#review89478
-----------------------------------------------------------



kcms/keyboard/keyboard_daemon.cpp (line 214)
<https://git.reviewboard.kde.org/r/126333/#comment61238>

    Looks like getDisplayName() could/should be improved then? I mean if it's not "good enough" for displaying it...


- Martin Klapetek


On Dec. 14, 2015, 12:49 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126333/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 12:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This makes the keyboard layout changed OSD show the same text as the tray icon would.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard_daemon.cpp 2a361fb 
> 
> Diff: https://git.reviewboard.kde.org/r/126333/diff/
> 
> 
> Testing
> -------
> 
> I now get "neo" and "de" instead of "de" and "de", identical to what my tray icon shows.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151214/81e51a1e/attachment-0001.html>


More information about the Plasma-devel mailing list