Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

René Fürst rene at fuerst.biz
Sun Dec 13 22:19:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125266/
-----------------------------------------------------------

(Updated Dez. 13, 2015, 10:19 nachm.)


Review request for Network Management and Plasma.


Changes
-------

Minor indetion fixes... Please note: this patch is now based on the latest revision.


Repository: plasma-nm


Description
-------

Authentication with certificates / Make MRU/MTU editable / Dialog fix


Diffs (updated)
-----

  vpn/l2tp/l2tp.ui bf35d02 
  vpn/l2tp/l2tpppp.ui 3c70165 
  vpn/l2tp/l2tppppwidget.cpp ffe2c2b 
  vpn/l2tp/l2tpwidget.h a161b53 
  vpn/l2tp/l2tpwidget.cpp a4ff42f 
  vpn/l2tp/nm-l2tp-service.h ac2ecc9 

Diff: https://git.reviewboard.kde.org/r/125266/diff/


Testing
-------

This patch contains 3 things:
1) Add authentication with certificates
2) Make MRU/MTU editable
3) Fix an issue where PPP/Advanced settings were lost when the dialogs were not opened

The base for 1) and 2) was added to NetworkManager-l2tp here https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c


Thanks,

René Fürst

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151213/71f3275c/attachment.html>


More information about the Plasma-devel mailing list