Review Request 126337: KCM Removable Devices: Fix enabling ui elements when changing global enabled setting

David Edmundson david at davidedmundson.co.uk
Sun Dec 13 20:56:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126337/#review89429
-----------------------------------------------------------

Ship it!


Would it be worth cutting this code in half by just setting them to the value of isChecked()?

- David Edmundson


On Dec. 13, 2015, 8:51 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126337/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2015, 8:51 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The logic was reverted, so when you enabled device auto-mounting, all ui were greyed out.
> 
> 
> Diffs
> -----
> 
>   solid-device-automounter/kcm/DeviceAutomounterKCM.cpp dba1d8c 
> 
> Diff: https://git.reviewboard.kde.org/r/126337/diff/
> 
> 
> Testing
> -------
> 
> Works now
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151213/5fed7537/attachment-0001.html>


More information about the Plasma-devel mailing list