Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled
Kai Uwe Broulik
kde at privat.broulik.de
Sun Dec 13 19:30:22 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126296/
-----------------------------------------------------------
(Updated Dec. 13, 2015, 7:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Martin Gräßlin.
Changes
-------
Submitted with commit 9b48e3d010d3e8cc8c592e39f2b07ffa5b0a76f1 by Kai Uwe Broulik to branch master.
Repository: plasma-framework
Description
-------
We were checking for Composite at compile-time but not at runtime causing a crash.
There was a bug about it but I can't find it.
Diffs
-----
src/declarativeimports/core/windowthumbnail.h 63d919f
src/declarativeimports/core/windowthumbnail.cpp 2b09657
Diff: https://git.reviewboard.kde.org/r/126296/diff/
Testing
-------
With Composite -> proper window thumbnail
Without Composite -> window icon (instead of crash)
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151213/81c13fe0/attachment.html>
More information about the Plasma-devel
mailing list