Review Request 126322: [ToolTip] Dismiss tooltip when item becomes invisible

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126322/#review89372
-----------------------------------------------------------



src/declarativeimports/core/tooltip.cpp (line 353)
<https://git.reviewboard.kde.org/r/126322/#comment61126>

    This seems a bit elaborate when there's a visibleChanged signal.
    
    Docs imply that all the propogation still affects the visible property.



src/declarativeimports/core/tooltip.cpp (line 357)
<https://git.reviewboard.kde.org/r/126322/#comment61125>

    you might want to check we're the item tooltip dialog is showing the tooltip for before we dismiss it.
    
    Otherwise this could remove someone else's tooltip.


Can you add a (manual) test to the existing tooltips test please.

- David Edmundson


On Dec. 11, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126322/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When an item containing a tooltip becomes invisible the tooltip would stay there indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.h d38c49b 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
> 
> Diff: https://git.reviewboard.kde.org/r/126322/diff/
> 
> 
> Testing
> -------
> 
> Hovered icon widget on my desktop, tooltip appeared, removed the widget through its context menu.
> 
> Before: tooltip would stay there until I either hovered another item or I commited the applet deletion.
> 
> Now: tooltip hides as soon as the applet disappeared
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151211/beb9dbd0/attachment-0001.html>