Review Request 126246: Add test for dynamically changing file definitions
Sebastian Kügler
sebas at kde.org
Fri Dec 11 13:57:47 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126246/#review89354
-----------------------------------------------------------
Ship it!
Ship It!
autotests/packagestructuretest.cpp (line 102)
<https://git.reviewboard.kde.org/r/126246/#comment61112>
ws (just because RB makes it totally red)
autotests/packagestructuretest.cpp (line 108)
<https://git.reviewboard.kde.org/r/126246/#comment61113>
seems unnecessary?
- Sebastian Kügler
On Dec. 4, 2015, 6:23 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126246/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 6:23 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> this, referred to https://git.reviewboard.kde.org/r/126244/ tests that adding or removing a file definition depending on the path (and whatever criteria, like metadata contents) works. since is already done in several places has to work correctly
>
>
> Diffs
> -----
>
> autotests/packagestructuretest.h de2038e
> autotests/packagestructuretest.cpp 4784bfd
>
> Diff: https://git.reviewboard.kde.org/r/126246/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151211/13946854/attachment.html>
More information about the Plasma-devel
mailing list