Review Request 126301: Add protocol for server side decoration

[Martin Gräßlin]

> On Dec. 10, 2015, 3:54 p.m., Marco Martin wrote:
> > src/client/protocols/server-decoration.xml, line 45
> > <https://git.reviewboard.kde.org/r/126301/diff/1/?file=421557#file421557line45>
> >
> >     do clients have to explicitly call that with risks of leaks?

sorry I don't get the question? It's the Wayland protocol way of saying from client side that it's no longer needed.


> On Dec. 10, 2015, 3:54 p.m., Marco Martin wrote:
> > src/client/protocols/server-decoration.xml, line 57
> > <https://git.reviewboard.kde.org/r/126301/diff/1/?file=421557#file421557line57>
> >
> >     the use case is that i can request a mode, but the server can ignore it and send me a different mode instead?

yes that would be possible. Like client sends "Client" and server answers with "None" because phone UI. In general it would acknowledge the Client's choice (use case yakuake, Plasma tooltips, etc.)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126301/#review89309
-----------------------------------------------------------


On Dec. 10, 2015, 3:03 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126301/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 3:03 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> [client] Add implementation for ServerSideDecoration
> 
> 
> [server] Add implementation for server side decoration protocol
> 
> 
> [autotest] Add tests for ServerSideDecoration protocol
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_registry.cpp 772da821d634efa1c72d13a7c081994bd78ab7fd 
>   autotests/client/CMakeLists.txt 014b5e0798618394ecf11c8b8cfa796dcf9c37f3 
>   autotests/client/test_server_side_decoration.cpp PRE-CREATION 
>   src/client/CMakeLists.txt 1d2b5492954e07fc77b2209a123ef8e43e340e8a 
>   src/client/protocols/server-decoration.xml PRE-CREATION 
>   src/client/registry.h c079852a4d96471face2a06795a531abf2e4d8c0 
>   src/client/registry.cpp 71640e184da4699bdc27a993b710b1f761c919d2 
>   src/client/server_decoration.h PRE-CREATION 
>   src/client/server_decoration.cpp PRE-CREATION 
>   src/server/CMakeLists.txt cd5c7bb1a93a470fd58cb9c6d86068da961addeb 
>   src/server/display.h 154e0f0b4c00375ca7d7f0a980392877fe743f50 
>   src/server/display.cpp 81ea7316e3b77f6db95748339d3dfaa303333d33 
>   src/server/server_decoration_interface.h PRE-CREATION 
>   src/server/server_decoration_interface.cpp PRE-CREATION 
>   src/tools/mapping.txt 9dc8204d65092aa86f6ced8ae5a131a2f89018d0 
> 
> Diff: https://git.reviewboard.kde.org/r/126301/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151211/7c5004df/attachment.html>