Review Request 126302: [GCI] Make "comment" section of the timezones configuration searchable
David Edmundson
david at davidedmundson.co.uk
Thu Dec 10 15:35:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126302/#review89310
-----------------------------------------------------------
Ship it!
Nice work.
- David Edmundson
On Dec. 10, 2015, 2:53 p.m., Imran Tatriev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126302/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 2:53 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Here's a link for the task - https://codein.withgoogle.com/dashboard/task-instances/6228912182919168/
>
> P.S. As coding style says: "Try to keep lines shorter than 100 characters, inserting line breaks as necessary.", therefore I've continued on a new line.
> P.S.S I have write access, so if you're ok with this patch, I can push it. ;)
>
>
> Diffs
> -----
>
> applets/digital-clock/plugin/timezonemodel.cpp 5d23505
>
> Diff: https://git.reviewboard.kde.org/r/126302/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> "comment" section works just fine!
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/efd530e3-9c81-40f2-be7a-14c89192b71a__comment_section.png
>
>
> Thanks,
>
> Imran Tatriev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151210/1d3194c0/attachment.html>
More information about the Plasma-devel
mailing list