Review Request 126300: Plasma Search KCM: display the runner descriptions
Jonathan Marten
jjm at keelhaul.me.uk
Thu Dec 10 14:01:02 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-desktop
Description
-------
In Plasma 5 this KCM only lists the names of the available runners, with no explanation of what they do. In its previous incarnation in KDE4 (the dropdown list from the runner config button), the descriptions were displayed. This change restores them.
Diffs
-----
kcms/runners/kcm.h f1239ee454cf40c3721743d5c771b4686d449d21
kcms/runners/kcm.cpp 4af82de9c385725a23cc09a074c5803f11a7945f
Diff: https://git.reviewboard.kde.org/r/126300/diff/
Testing
-------
Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen and older styles.
File Attachments
----------------
Screenshot before
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Thanks,
Jonathan Marten
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151210/9226c7df/attachment-0001.html>
More information about the Plasma-devel
mailing list