Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"
Rex Dieter
rdieter at gmail.com
Thu Dec 10 01:18:31 UTC 2015
> On Dec. 9, 2015, 11:03 p.m., Rex Dieter wrote:
> > I (still) think it should be renamed and Wayland mentioned *somewhere*. Not all login managers distinguish wayland sessions like sddm does.
>
> David Edmundson wrote:
> Though if you do SDDM will say:
>
> Plasma (wayland) (wayland)
>
> Rex Dieter wrote:
> If need be, yes.
>
> Aleix Pol Gonzalez wrote:
> AFAIR, SDDM is the only one officially supported by Plasma. It's not really acceptable that it has visual regressions.
>
> Martin Klapetek wrote:
> I agree with Rex though, imo it should be up to the desktop to
> provide the "wayland" string in its file rather than sddm itself.
> Our stuff shouldn't make assumptions about its visual representations.
to put another way, some downstreams will need to patch in a wayland identifier (fedora included), i'd rather that not be the case
- Rex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126275/#review89286
-----------------------------------------------------------
On Dec. 8, 2015, 2:09 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126275/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 2:09 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The commit/review says it's displayed as "Plasma (Wayland)"
> but the name is just "Plasma", making it confusing in login
> manager.
>
>
> Diffs
> -----
>
> plasmawayland.desktop.cmake c5d5757
>
> Diff: https://git.reviewboard.kde.org/r/126275/diff/
>
>
> Testing
> -------
>
> Sddm now clearly shows which "Plasma" is Waylandplasma.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151210/31b99b73/attachment.html>
More information about the Plasma-devel
mailing list