Review Request 126292: [CompactApplet] Hack to force focus on expanded representation

Marco Martin notmart at gmail.com
Wed Dec 9 22:14:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126292/#review89285
-----------------------------------------------------------


Dialog has the focus correctly to its mainItem, right?
so in here you could set the focus on the full representation when its parent (mainItem) gets it, without having to use a timer?


desktoppackage/contents/applet/CompactApplet.qml (line 140)
<https://git.reviewboard.kde.org/r/126292/#comment61059>

    ugh, has it really to be a second timer?


- Marco Martin


On Dec. 9, 2015, 9:21 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126292/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 9:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> By default the Dialog's mainItem (some QQuickRootSomething item) has focus which doesn't seem to forward any key events. To workaround this I force focus on the actual expanded representation in case it didn't already force it elsewhere.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/applet/CompactApplet.qml cbc222e 
> 
> Diff: https://git.reviewboard.kde.org/r/126292/diff/
> 
> 
> Testing
> -------
> 
> I now get keyboard events to plasma popups that just use Keys instead of manually messing with focus like Kickoff but I'm open to better suggestions :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151209/223beff2/attachment-0001.html>


More information about the Plasma-devel mailing list