Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"
Martin Gräßlin
mgraesslin at kde.org
Wed Dec 9 06:51:42 UTC 2015
> On Dec. 8, 2015, 7:51 a.m., Martin Gräßlin wrote:
> > -2 for another reason: the display system should not be a user facing part. That's a technical detail which will go away in a year or two. Do you want to rename it back to Plasma then? If at all we should change the X11 session to have the name adjusted.
>
> David Edmundson wrote:
> If you think that, why provide the .desktop file at all when it's not ready?
>
> Sebastian Kügler wrote:
> I think as long as Wayland is the experimental option, it should say so. The specialization makes it easier to recognize the stable/X11 session.
>
> David Edmundson wrote:
> What I don't get is why we're installing this file by default at all.
> We *know* that without a kdeinit patch everything freezes. So we've just added an option that we *know* will only give a black screen. That's both pointless and setting a bad impression.
>
> Martin Gräßlin wrote:
> > We know that without a kdeinit patch everything freezes.
>
> To be fair I didn't know that it would freeze when the session file got added. I thought it was related to another KDE session running and not just to sddm having started an X server.
>
> > That's both pointless and setting a bad impression.
>
> We are not installing the file. Distros are. I don't expect any sane distro to provide the wayland session installed by default. It should be possible to install it, though and this includes a patched kdeinit. This is something AFAIK Arch already did before we provided the session file.
>
> Hrvoje Senjan wrote:
> It is installed by CMake w/o any patches and is said to be provided in the release announcement, so i guess it is safe to say that it is installed by default.
>
> If upstream would prefer the session is not provided, best is 1) don't install it at all via CMake, 2) notify kde-distro-packagers that the session should rather not be provided.
I have now sent a mail to release-team to clarify that I expect the Wayland session to be moved into a dedicated package which does not get installed by default.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126275/#review89235
-----------------------------------------------------------
On Dec. 8, 2015, 3:09 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126275/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 3:09 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The commit/review says it's displayed as "Plasma (Wayland)"
> but the name is just "Plasma", making it confusing in login
> manager.
>
>
> Diffs
> -----
>
> plasmawayland.desktop.cmake c5d5757
>
> Diff: https://git.reviewboard.kde.org/r/126275/diff/
>
>
> Testing
> -------
>
> Sddm now clearly shows which "Plasma" is Waylandplasma.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151209/66bc9db5/attachment.html>
More information about the Plasma-devel
mailing list