Review Request 126268: Move shutdown scripts into ksmserver cleanup
David Edmundson
david at davidedmundson.co.uk
Tue Dec 8 13:54:11 UTC 2015
> On Dec. 8, 2015, 12:37 a.m., Alex Richardson wrote:
> > ksmserver/server.cpp, line 1105
> > <https://git.reviewboard.kde.org/r/126268/diff/2/?file=421193#file421193line1105>
> >
> > continue?
ooh, very good spot. Fixed
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126268/#review89231
-----------------------------------------------------------
On Dec. 7, 2015, 12:26 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126268/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 12:26 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Shutdown scripts are done by startkde after ksmserver quits. Which never
> happens because we've told systemd to shutdown.
>
> Old systems worked because they used to communicate with the display
> manager which then closed us before shutting down, this is no longer the
> case.
>
> This moves handling the shutdown scripts into ksmserver (which already
> handles startup scripts) and runs them before asking logind to shutdown.
>
> BUG: 356190
>
>
> Diffs
> -----
>
> ksmserver/server.h 1a2f0810c53d508d7d721fb4be1c25f0585c0602
> ksmserver/server.cpp 9477e542399ad65f993e581fc4212883f282b70e
> startkde/startkde.cmake 41a8975cce1fb2a4e7a034e697ce6e2cc59d5b1e
> startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8
>
> Diff: https://git.reviewboard.kde.org/r/126268/diff/
>
>
> Testing
> -------
>
> had a shutdown script to touch a file in my home, worked for shutdown and logout.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151208/137b4397/attachment.html>
More information about the Plasma-devel
mailing list