Review Request 126268: Move shutdown scripts into ksmserver cleanup

[Matthias Klumpp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126268/#review89227
-----------------------------------------------------------

Ship it!


Good thing!
I wasted a few hours yesterday in finding out why this works, just to come to the conclusion that it can't possibly work.
Thank you for the explanation, this does make more sense to me now :)

- Matthias Klumpp


On Dez. 7, 2015, 12:26 vorm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126268/
> -----------------------------------------------------------
> 
> (Updated Dez. 7, 2015, 12:26 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Shutdown scripts are done by startkde after ksmserver quits. Which never
> happens because we've told systemd to shutdown.
> 
> Old systems worked because they used to communicate with the display
> manager which then closed us before shutting down, this is no longer the
> case.
> 
> This moves handling the shutdown scripts into ksmserver (which already
> handles startup scripts) and runs them before asking logind to shutdown.
> 
> BUG: 356190
> 
> 
> Diffs
> -----
> 
>   ksmserver/server.h 1a2f0810c53d508d7d721fb4be1c25f0585c0602 
>   ksmserver/server.cpp 9477e542399ad65f993e581fc4212883f282b70e 
>   startkde/startkde.cmake 41a8975cce1fb2a4e7a034e697ce6e2cc59d5b1e 
>   startkde/startplasma.cmake 8360a636d3f68c957a15158484360a611cfe3ff8 
> 
> Diff: https://git.reviewboard.kde.org/r/126268/diff/
> 
> 
> Testing
> -------
> 
> had a shutdown script to touch a file in my home, worked for shutdown and logout.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151207/dd177bbb/attachment-0001.html>