Review Request 126244: Let containments override CompactApplet.qml

David Edmundson david at davidedmundson.co.uk
Fri Dec 4 16:28:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126244/#review89128
-----------------------------------------------------------


Seems sensible enough.


src/plasma/private/packages.cpp (line 128)
<https://git.reviewboard.kde.org/r/126244/#comment61003>

    Having the content structure change when you load a specific package is going to result in weird behaviour. 
    
    package.files() should be usable from just the structure.


- David Edmundson


On Dec. 4, 2015, 3:34 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126244/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 3:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> the CompactApplet file from the shell package defines the behavior of the poopup applets in the panel (it implements an internal dialog and all that jazz)
> implementing a simplified systray(both the one for the phone and a separate one for the desktop), i noticed that a containment may have different ideas on how to expand an applet: the systray would have for instance a single popup dialog and put all of its applet full representtions in the same Dialog , this lets containment representation to override that file (*if* won't get abused, that's the only thing makes me a bit on the fence about this)
> It would make possible also fairly different designs that have been proposed in the past, such as the bug sidebar similar to the "charm bar"
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/packages.cpp c04d36d 
>   src/plasma/private/packages_p.h a7c4cb1 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/private/appletquickitem_p.h 79c1a2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126244/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151204/1529c69a/attachment-0001.html>


More information about the Plasma-devel mailing list