Review Request 126234: Fix build with Qt 5.6

Jan Kundrát jkt at kde.org
Fri Dec 4 09:23:56 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 9:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.


Changes
-------

Submitted with commit 7c8adeff9ec9e16bf0ad2971d5edeb484a302e6b by Jan Kundrát to branch master.


Repository: kwin


Description
-------

Fix build with Qt 5.6

A recent change [1] led to Qt5PlatformSupport.pc not being installed
anymore. Pkg-config was only used for finding the paths, and the actual
include flags and library names were hardcoded in KWin's
FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
Qt5Gui, the module which provides this Qt5PlatformSupport library, and
work from there.

Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
Gerrit change.

[1] https://codereview.qt-project.org/140954/

REVIEW: 126234


Diffs
-----

  cmake/modules/FindQt5PlatformSupport.cmake 90a8438ac80e48b09463ba5f34a72b2d7567ea5d 

Diff: https://git.reviewboard.kde.org/r/126234/diff/


Testing
-------


Thanks,

Jan Kundrát

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151204/a68909cc/attachment.html>


More information about the Plasma-devel mailing list