Review Request 126234: Fix build with Qt 5.6

Martin Gräßlin mgraesslin at kde.org
Fri Dec 4 07:15:54 UTC 2015



> On Dec. 3, 2015, 6:51 p.m., Hrvoje Senjan wrote:
> > 2nd best solution after not using Qt5PlatformSupport at all :D

well we have to :-( I wanted to not rely on it, but we need it to get working fonts.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126234/#review89090
-----------------------------------------------------------


On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126234/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 6:37 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Hrvoje Senjan.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Fix build with Qt 5.6
> 
> A recent change [1] led to Qt5PlatformSupport.pc not being installed
> anymore. Pkg-config was only used for finding the paths, and the actual
> include flags and library names were hardcoded in KWin's
> FindQt5PlatformSupport.cmake anyway, so let's just focus on finding
> Qt5Gui, the module which provides this Qt5PlatformSupport library, and
> work from there.
> 
> Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream
> Gerrit change.
> 
> [1] https://codereview.qt-project.org/140954/
> 
> REVIEW: 126234
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQt5PlatformSupport.cmake 90a8438ac80e48b09463ba5f34a72b2d7567ea5d 
> 
> Diff: https://git.reviewboard.kde.org/r/126234/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151204/c73004f9/attachment.html>


More information about the Plasma-devel mailing list