Review Request 126210: [phonon] Do not set RPATH
Alex Richardson
arichardson.kde at gmail.com
Thu Dec 3 23:02:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126210/#review89096
-----------------------------------------------------------
+1
I think RPATH stuff is already set up correctly by extra-cmake-modules so there should be no need for that code
- Alex Richardson
On Nov. 30, 2015, 7:16 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126210/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 7:16 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This very old piece of code triggers a scanelf warning during build. I don't know why it is there, hopefully someone knows.
>
>
> Diffs
> -----
>
> phonon/platform_kde/CMakeLists.txt 281425fb6f6c1a41f14399ac17f8a94cd99507ad
>
> Diff: https://git.reviewboard.kde.org/r/126210/diff/
>
>
> Testing
> -------
>
> Builds, and runs (unfortunately can't run the tests), phonon test playback included.
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151203/0a7098fe/attachment.html>
More information about the Plasma-devel
mailing list