Review Request 126221: Rework the notifications positioning a bit

[Martin Klapetek]

> On Dec. 3, 2015, 12:36 a.m., Mark Gaiser wrote:
> > I had this issue for quite a while!
> > It's in bug #349669, i have high hopes that this change fixes my case as well :)
> > 
> > Will try this out somewhere this weekend.

No, unfortunately this will not fix this issue, but it is related.
It's the same problem, in fact, but as the notifications use manual
positioning on the screen, it needs a fix in that code first.

Afaiu the problem happens when something positions a window "out of
bounds", ie. out of screen and/or in panel struts, then something else
takes it (either KWin or Qt/X11 or PlasmaQuick::Dialog) and puts it
back within bounds, but with y=0. Unfortunately I don't understand
window placement enough to precisely pinpoint where/why it goes to y=0.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126221/#review89064
-----------------------------------------------------------


On Dec. 2, 2015, 8:32 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126221/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355069
>     https://bugs.kde.org/show_bug.cgi?id=355069
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The notifications popup positioning recently regressed
> by some other changes (looks like Qt) and the popups
> would fly across the screen (bug 355069).
> 
> The proper solution is using KWin effect but given how
> close the release is, this needs to be dealt with in a
> different way.
> 
> The main problem is calculating the initial popup size
> because as long as the Dialog is invisible, it has an
> incorrect geometry, so it needs to be positioned right
> after it's being displayed. The Dialog however gets the
> sizes even later, so the code now calls a slot from Dialog
> that ensures the sizes are correct before the initial
> placement on screen. It's not ideal but I'm out of ideas
> otherwise. Plus it should be only temporary until the
> KWin effect will replace it.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/lib/notificationsapplet.cpp aa50aef 
>   applets/notifications/package/contents/ui/Notifications.qml 306169c 
>   applets/notifications/plugin/notificationshelper.h cb9b335 
>   applets/notifications/plugin/notificationshelper.cpp 7c0dd99 
>   applets/notifications/lib/notificationsapplet.h dc31e1d 
> 
> Diff: https://git.reviewboard.kde.org/r/126221/diff/
> 
> 
> Testing
> -------
> 
> I can no longer reproduce notifications flying across
> the screen.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151202/ac7057be/attachment.html>