Review Request 126207: [Compact Applet] Don't break the dialog size binding

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126207/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 11:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit b0ebdbb4c63fd84ae95b3e35bdf40f25e1f10c06 by Kai Uwe Broulik to branch Plasma/5.5.


Repository: plasma-desktop


Description
-------

We must not break the binding on the dialog's size, otherwise changing the preferredWidth/height of a dialog won't affect it.


Diffs
-----

  desktoppackage/contents/applet/CompactApplet.qml b5bbc70 

Diff: https://git.reviewboard.kde.org/r/126207/diff/


Testing
-------

I wasted hours on finding out why User Manager dialog sizing was broken, re-writing it several times /o\

Changing Layout.preferredHeight changes the dialog size, Layout.minimumHeight/Layout.maximumHeight constraints still work. Didn't notice breakage with other applets.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151201/5745e332/attachment.html>