Review Request 126203: Disable ptrace for kcheckpass and the greeter

[Martin Gräßlin]

> On Dec. 1, 2015, 11:04 a.m., Raphael Kubo da Costa wrote:
> > CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/126203/diff/2/?file=420269#file420269line25>
> >
> >     This is being checked for here but not set in `config-kscreenlocker.h.cmake`, so the header is still being included unconditionally.
> 
> Martin Gräßlin wrote:
>     sorry, I don't get what you mean. I added a cmakedefine01 to config-kscreenlocker.h.cmake
> 
> Raphael Kubo da Costa wrote:
>     You only added a cmakedefine01 for the result of the `check_symbol_exists()` call, but nothing is being done about the `check_include_file()` one, which was presumably added for you to only include `sys/prctl.h` in the code if it was found. In other words:
>     
>     ```
>     #include <config-kscreenlocker.h>
>     #if defined(HAVE_SYS_PRCTL_H)
>     #  include <sys/prctl.h>
>     #endif
>     ```

oh right, I just thought that sys/prctl.h is available on all platforms we care about.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126203/#review88989
-----------------------------------------------------------


On Dec. 1, 2015, 8:34 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126203/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 8:34 a.m.)
> 
> 
> Review request for Plasma and Tobias Berner.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> -------
> 
> Setting the PR_SET_DUMPABLE flag to 0 for the security relevant
> command kcheckpass and kscreenlocker_greet. If one wants to gdb into
> the running command it will result in:
> 
> ptrace: Operation not permitted.
> 
> For kscreenlocker_greet ptrace is permitted in testing mode.
> 
> As root it's still possible to attach to the process.
> 
> ---
> 
> @Tobias: I assume this is a strong linux-ism. Is there a FreeBSD compareable functionality?
> 
> I'm considering to push this explicitly without an ifdef. It's a new security feature and I want to make non-Linux systems aware of the fact that it adds a new feature and that a replacement should be added.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f48bd53cafc188f79e041518dae0769d57597c69 
>   config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
>   greeter/main.cpp e4e679e7ef40b319665428281fdba5f4e0b4eb25 
>   kcheckpass/kcheckpass.c fd2d2215bf2199f159a121bb0ce08e7b2b254aaa 
> 
> Diff: https://git.reviewboard.kde.org/r/126203/diff/
> 
> 
> Testing
> -------
> 
> Tried to gdb into the processes: failed
> Tried to gdb into kscreenlocker_greet --testing: succeeded
> Tried to gdb into kscreenlocker_greet as root: succeeded
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151201/37d021a0/attachment-0001.html>