Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

David Edmundson david at davidedmundson.co.uk
Tue Dec 1 11:17:28 UTC 2015



> On Dec. 1, 2015, 9 a.m., David Edmundson wrote:
> > Looks good. Thanks for that.
> > 
> > Do you have commmit access?
> 
> Anthony Fieroni wrote:
>     No, i hope will see it for 5.5 :)
> 
> David Edmundson wrote:
>     I've just moved a bit of code so it's now: https://paste.kde.org/pmebpx2tm
>     
>     you ok with that?
> 
> Anthony Fieroni wrote:
>     About me, this will NOT work. Why you do this? Will work if remove line 31 :) Mouse move is triggered, but cursor is outside the panel - this code will not make nothing.

We only get mouse events outside the panel in two conditions:
 - leave events (which we still have)
 - drags (which we dont' want to generated new leave events on)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88985
-----------------------------------------------------------


On Nov. 30, 2015, 8:26 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 8:26 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
>     https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> -------
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave	11	Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151201/65922c59/attachment.html>


More information about the Plasma-devel mailing list