Review Request 126203: Disable ptrace for kcheckpass and the greeter

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126203/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 8:34 a.m.)


Review request for Plasma and Tobias Berner.


Changes
-------

added a cmake check for the linux part and added it to feature info. For other systems I suggest to extend this once this review is in (sorry I don't dare to add security relevant code which I cannot even compile ;-) ).


Repository: kscreenlocker


Description
-------

Setting the PR_SET_DUMPABLE flag to 0 for the security relevant
command kcheckpass and kscreenlocker_greet. If one wants to gdb into
the running command it will result in:

ptrace: Operation not permitted.

For kscreenlocker_greet ptrace is permitted in testing mode.

As root it's still possible to attach to the process.

---

@Tobias: I assume this is a strong linux-ism. Is there a FreeBSD compareable functionality?

I'm considering to push this explicitly without an ifdef. It's a new security feature and I want to make non-Linux systems aware of the fact that it adds a new feature and that a replacement should be added.


Diffs (updated)
-----

  CMakeLists.txt f48bd53cafc188f79e041518dae0769d57597c69 
  config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
  greeter/main.cpp e4e679e7ef40b319665428281fdba5f4e0b4eb25 
  kcheckpass/kcheckpass.c fd2d2215bf2199f159a121bb0ce08e7b2b254aaa 

Diff: https://git.reviewboard.kde.org/r/126203/diff/


Testing
-------

Tried to gdb into the processes: failed
Tried to gdb into kscreenlocker_greet --testing: succeeded
Tried to gdb into kscreenlocker_greet as root: succeeded


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151201/b44450d1/attachment.html>