Review Request 108798: Fix most of the compile issues due to wrong header used and comment out in shell/CMakeLists.txt testapplet which doesn't exist

[Shawn Starr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108798/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 9:17 p.m.)


Status
------

This change has been discarded.


Review request for Plasma, Aaron J. Seigo and Marco Martin.


Repository: plasma-framework


Description
-------

Trying to build plasma-framework I encountered some headers using 3rd party names vs internal and I believe these should all be internal headers? Fixing those and commenting out one of the testcase apps gets it to build. Although there's other issues with not linking kdecore/ui etc properly. Given this code is in heavy development, you may disregard this review request but I'd still like to go though the process.

btw, I'm back ;)


Diffs
-----

  scriptengines/qml/common/scriptenv.cpp b79cd3d 
  declarativeimports/core/framesvgitem.h fb4741a 
  scriptengines/qml/declarative/packageaccessmanager.h 3e9a712 
  scriptengines/qml/declarative/packageaccessmanagerfactory.h 70e4eb9 
  scriptengines/qml/plasmoid/abstractjsappletscript.h cdd709c 
  scriptengines/qml/plasmoid/appletauthorization.cpp 6fe9454 
  scriptengines/qml/plasmoid/appletinterface.h 6226802 
  scriptengines/qml/plasmoid/appletinterface.cpp f5dc187 
  scriptengines/qml/plasmoid/declarativeappletscript.h 18b324b 
  scriptengines/qml/plasmoid/declarativeappletscript.cpp 75d25eb 
  shell/CMakeLists.txt ecbfad9 

Diff: https://git.reviewboard.kde.org/r/108798/diff/


Testing
-------

Able to build things, but didn't look into why proper KDE libraries not being linked in yet (editing the generated CMakefiles/component.dir/link.txt works around this for now)


Thanks,

Shawn Starr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/823702f7/attachment.html>