Review Request 124114: Add "Lock Screen" to desktop toolbox

[Jeremy Whiting]

> On June 16, 2015, 9:29 p.m., David Edmundson wrote:
> > > This does not check KAuthorized before to hide the entry but neither does the context menu.
> > 
> > Well that's a bit rubbish. 
> > Ship this, but lets remember to fix both, poke me if it gets near release and I haven't.
> > 
> > BTW, is it possible to power this menu from the QActions we have in Plasma, I haven't looked but it should reduce some code?
> 
> Kai Uwe Broulik wrote:
>     I don't know, the context menu containment action generates a bunch of QActions as well as the global shortcuts

Kai, David, Any update on this?


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124114/#review81518
-----------------------------------------------------------


On June 16, 2015, 2:18 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124114/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 2:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> It used to be present in 4.x and makes it consistent with what the context menu provides. This does not check KAuthorized before to hide the entry but neither does the context menu. As suggested in https://forum.kde.org/viewtopic.php?f=289&t=126770
> 
> 
> Diffs
> -----
> 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml c2a36e9 
> 
> Diff: https://git.reviewboard.kde.org/r/124114/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> File Attachments
> ----------------
> 
> Lock screen entry
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/16/1c037bef-4280-4da8-bf9c-7cdc3d0e37b6__lockscreentoolbox.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/4bc79d0a/attachment.html>