Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124947/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 12:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
-------

Submitted with commit 7e1a4df817bdd156352ac9b37eac01837ed25204 by Martin Gräßlin to branch master.


Repository: plasma-workspace


Description
-------

In a multi-screen setup we have multiple views showing the same Qml
scene. Let's share the engine for all views.


Diffs
-----

  ksmserver/screenlocker/greeter/CMakeLists.txt 4fb679f838a80f11eb8e4b4f5cb5ef04dc39c0f7 
  ksmserver/screenlocker/greeter/greeterapp.h ed278e492a9a237f65f4c1600360f84fb25bdad7 
  ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c 

Diff: https://git.reviewboard.kde.org/r/124947/diff/


Testing
-------

This makes creating a second view basically free (from timing perspective)


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/22723a98/attachment.html>