Review Request 119344: add close button to fullscreen mode, bug #319099

David Edmundson david at davidedmundson.co.uk
Mon Aug 31 10:51:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119344/#review84631
-----------------------------------------------------------


Plasma people, remember to ask if someone has commit access when clicking ship it. Otherwise these stay in limbo.

It's our job to chase up after these things.

As for this patch 4.x are not being released any more, so I'm going to have to close this.

- David Edmundson


On July 17, 2014, 4:41 p.m., Drake Justice wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119344/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 4:41 p.m.)
> 
> 
> Review request for Homerun and Plasma.
> 
> 
> Repository: homerun
> 
> 
> Description
> -------
> 
> adds a close button to the topright of fullscreen, only visible if not a containment. 
> 
> 
> Diffs
> -----
> 
>   fullscreen/package/contents/ui/main.qml d7d52a1 
> 
> Diff: https://git.reviewboard.kde.org/r/119344/diff/
> 
> 
> Testing
> -------
> 
> desktop containment and panel containment. 
> 
> 
> Thanks,
> 
> Drake Justice
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/226bc2dd/attachment.html>


More information about the Plasma-devel mailing list