Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124933/#review84626
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 27, 2015, 6:36 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124933/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 6:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This fixes type errors shown on startup:
> TypeError: Cannot read property 'showPassword' of undefined
> TypeError: Cannot read property 'ButtonLabel' of undefined
> 
> REVIEW: 124931
> 
> [screenlocker] Try to load faster by using more loaders
> 
> All UI is put into a loader to get the actual lock screen loaded faster.
> This gets the creation of two views down to about < 600 msec from before
> around 1.8 sec. The initial startup time is extremely important to ensure
> the screen is properly locked when going to suspend.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c 
>   lookandfeel/contents/lockscreen/ChangeSession.qml PRE-CREATION 
>   lookandfeel/contents/lockscreen/LockOsd.qml PRE-CREATION 
>   lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 
>   lookandfeel/contents/lockscreen/MainBlock.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124933/diff/
> 
> 
> Testing
> -------
> 
> the OSD is not anchored correctly any more.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150831/c5bd8bdf/attachment.html>