Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

[David Kahles]

> On Aug. 30, 2015, 3:28 p.m., David Edmundson wrote:
> > This needs reverting.
> > 
> > Check wallpaper configuration now.
> 
> David Edmundson wrote:
>     Explaining this a bit better.
>     
>     What the code was doing before:
>      height is either: 
>        the size of the child items
>        filling up all the way to the buttons at the bottom of the dialog
>     
>     The problem it's trying to solve is we have sometimes have content of variable height in a scrollview; which needs to know the content height.
>     
>     This is a bit of a loop logically.
>     
>     I'm not convinced your patch makes much sense, you've got the height of the stackview is the height of the title which is above the stackview.
>     
>     I think the best way to fix the binding loop will be to use a mix of height and implicitHeight - so we don't end up using the same property for two things which is where it get confusing.

Thanks for the hint and the explanation. I reverted the commit and will hopefully come up with a better soultion.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124953/#review84578
-----------------------------------------------------------


On Aug. 27, 2015, 4:47 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124953/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 4:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Calculate the height of the stackview without using the viewport height
> to prevent a binding loop, because te viewportheight changes when the
> stackviewheight changes. Thus, the height of the main stackview could
> not be reduced but only increased.
> 
> Please double check as I don't know much about applets in generell..
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a572d0e4567677ea95e5606427537fa3ff 
> 
> Diff: https://git.reviewboard.kde.org/r/124953/diff/
> 
> 
> Testing
> -------
> 
> The height of the main stackview in the pa-applet configuration couldn't be decreased which led to an unnecessary scrollbar and a binding loop warning.
> After applying this patch, the height can be decreased and the scrollbar and the warning disappeared.
> I coundn't find this bug in any other applet configurations. (Maybe they're using different technics, don't know that)
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150830/d4535350/attachment.html>