Review Request 124981: RFC: Move context menu out of panel

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124981/#review84577
-----------------------------------------------------------

Ship it!


We're quite close to the release, so I'd rather you waited till just after this gets tagged just in case of any problems

- David Edmundson


On Aug. 29, 2015, 5:12 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124981/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 5:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This is one thing that got lost in the transition from 4 to 5 is that context menus don't overlap the panel. The only place that still does that is the SNI but everything else just shows the context menu right at the cursor.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 104581d 
> 
> Diff: https://git.reviewboard.kde.org/r/124981/diff/
> 
> 
> Testing
> -------
> 
> Applet context menus in panels no longer overlap the panel, covering the applet I just clicked. I'm not sure about this approach; 4.x had a applet->popupPosition() which apparently did magic like Dialog does nowadays. Did not test with multiple monitors.
> 
> Also it needs adjustment in at least the panel context menu and task manager to provide a consistent feel.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150830/5286b959/attachment.html>