Review Request 124992: Update currentSize in Screen::apply

Daniel Vrátil dvratil at kde.org
Sun Aug 30 12:03:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124992/#review84572
-----------------------------------------------------------

Ship it!


Thanks for the patch!

- Daniel Vrátil


On Aug. 30, 2015, 7:46 a.m., Andrew Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124992/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 7:46 a.m.)
> 
> 
> Review request for Plasma and Daniel Vrátil.
> 
> 
> Bugs: 352001
>     http://bugs.kde.org/show_bug.cgi?id=352001
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> currentSize can be changed due to addition, removal, or change of resolution of outputs, therefore it should be updated in Screen::apply.
> Correctly updating currentSize will allow plasmashell to be notified of a change in screen size.
> 
> 
> Diffs
> -----
> 
>   src/screen.cpp 6d1c5d8df1e3b67c79a4c2c71338a21f49835380 
> 
> Diff: https://git.reviewboard.kde.org/r/124992/diff/
> 
> 
> Testing
> -------
> 
> It works
> 
> 
> Thanks,
> 
> Andrew Chen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150830/0c7898a7/attachment.html>


More information about the Plasma-devel mailing list