Review Request 124966: [screenlocker] Filter out XCB_FOCUS_OUT events in the screenlocker

[David Edmundson]

> On Aug. 28, 2015, 11:25 a.m., David Edmundson wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 83
> > <https://git.reviewboard.kde.org/r/124966/diff/1/?file=399467#file399467line83>
> >
> >     if (XCB_EVENT_RESPONSE_TYPE(event->response_type) == XCB_FOCUS_OUT)
> 
> Martin Gräßlin wrote:
>     what is that XCB_EVENT_RESPONSE_TYPE?

a macro that does ( & 0x7f) 

so the same as what you've written, but without needing weird magic numbers.


On Aug. 28, 2015, 11:25 a.m., Martin Gräßlin wrote:
> > does this actually work? the other window still has the actual focus we'll just keep happily blinking our cursor because we think we do.
> > 
> > if you do your krunner case and then type something after 10 seconds does it appear as you'd expect?
> 
> Martin Gräßlin wrote:
>     of course it does ;-) The lock window has a keyboard grab anyway.

\o/


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124966/#review84530
-----------------------------------------------------------


On Aug. 28, 2015, 11:17 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124966/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 11:17 a.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The screenlocker has always focus, the backend is sending it events.
> So let's not allow X to tell Qt it doesn't have focus.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp b500ba44c2b483d7372ca46840152c90ef5f798c 
> 
> Diff: https://git.reviewboard.kde.org/r/124966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150828/22252bff/attachment.html>