Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

[David Kahles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124953/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 4:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
-------

Calculate the height of the stackview without using the viewport height
to prevent a binding loop, because te viewportheight changes when the
stackviewheight changes. Thus, the height of the main stackview could
not be reduced but only increased.

Please double check as I don't know much about applets in generell..


Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a572d0e4567677ea95e5606427537fa3ff 

Diff: https://git.reviewboard.kde.org/r/124953/diff/


Testing
-------

The height of the main stackview in the pa-applet configuration couldn't be decreased which led to an unnecessary scrollbar and a binding loop warning.
After applying this patch, the height can be decreased and the scrollbar and the warning disappeared.
I coundn't find this bug in any other applet configurations. (Maybe they're using different technics, don't know that)


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150827/d6504caf/attachment-0001.html>