Review Request 124937: Add comment/description to keyboard kded module

David Edmundson david at davidedmundson.co.uk
Wed Aug 26 22:11:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124937/#review84430
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 26, 2015, 5:41 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124937/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm.
> 
> AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment:
> `Enables system tray for changing keyboard layout`
> 
> If the module provides other functionality, we can revise the comment.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/keyboard.desktop 43ae1f1 
> 
> Diff: https://git.reviewboard.kde.org/r/124937/diff/
> 
> 
> Testing
> -------
> 
> A description is now provided in the kded kcm.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/2873a2c1/attachment.html>


More information about the Plasma-devel mailing list