Review Request 124937: Add comment/description to keyboard kded module
Ragnar Thomsen
rthomsen6 at gmail.com
Wed Aug 26 17:08:06 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124937/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 7:08 p.m.)
Review request for Plasma.
Changes
-------
Add before+after screenshots.
Repository: plasma-desktop
Description
-------
The desktop file for the keyboard kded module was missing the comment field. This results in a missing description in the kded kcm.
AFAICT from the code the keyboard kded module enables the system tray for switching keyboard layout, so I added the comment:
`Enables system tray for changing keyboard layout`
If the module provides other functionality, we can revise the comment.
Diffs
-----
kcms/keyboard/keyboard.desktop 43ae1f1
Diff: https://git.reviewboard.kde.org/r/124937/diff/
Testing
-------
A description is now provided in the kded kcm.
File Attachments (updated)
----------------
Before
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png
After
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png
Thanks,
Ragnar Thomsen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/38eb1f6f/attachment-0001.html>
More information about the Plasma-devel
mailing list