Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

[David Kahles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124782/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 4:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c4617a65b2bfdad2b0bb3274c08f3a45d2c3c4eb by David Kahles to branch master.


Repository: plasma-desktop


Description
-------

Add some comments to this IHMO hard to understand code.
I hope I understood the code correctly...

The maximum and minimum position the slider can be moved to is not
relative to offset, so min/maxValue is a wrong term. Instead, use
min/maxPosition as the borders are absolute.


Diffs
-----

  desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 
  desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a 

Diff: https://git.reviewboard.kde.org/r/124782/diff/


Testing
-------

Changing the size and position works as before.


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/3ea0a99a/attachment-0001.html>