Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124785/#review84409
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 17, 2015, 9:31 a.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124785/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 9:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> As offset and length have a different meaning in all alignments, the
> panel shifts on alignment change. This could result in wrong panel
> positions (e.g. panel shifted over a monitor border). The better approach
> would be the recalculation of all values, so that the panel stays at it's
> current position, but this would be error prone and complicated. As the
> panel alignment is rarely changed, it's not worth it. The more easy
> approach is just setting the panel offset to zero. This makes sure the
> panel has a valid position and size.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 
> 
> Diff: https://git.reviewboard.kde.org/r/124785/diff/
> 
> 
> Testing
> -------
> 
> When changing the alignment, the offset gets 0, so there are no invalid panel positions on alignment change
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/ce305d84/attachment.html>