Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

[David Kahles]

> On Aug. 22, 2015, 11:31 p.m., David Edmundson wrote:
> > desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml, line 48
> > <https://git.reviewboard.kde.org/r/124782/diff/1/?file=395295#file395295line48>
> >
> >     this doesn't entirely make sense.
> >     
> >     
> >     alignment == AlignLeft
> >     
> >     will also be
> >     
> >     alignment & AlignLeft
> >     
> >     I assume in the third case it's
> >     AlignHCenter & AlignLeft

To be precise, it's 
    (alignment != Qt.AlignRight) && (alignment & Qt.AlignRight)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124782/#review84193
-----------------------------------------------------------


On Aug. 26, 2015, 5:52 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124782/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Add some comments to this IHMO hard to understand code.
> I hope I understood the code correctly...
> 
> The maximum and minimum position the slider can be moved to is not
> relative to offset, so min/maxValue is a wrong term. Instead, use
> min/maxPosition as the borders are absolute.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 
>   desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a 
> 
> Diff: https://git.reviewboard.kde.org/r/124782/diff/
> 
> 
> Testing
> -------
> 
> Changing the size and position works as before.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/7bc20770/attachment.html>