Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter

Kai Uwe Broulik kde at privat.broulik.de
Wed Aug 26 10:54:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124931/#review84399
-----------------------------------------------------------



lookandfeel/contents/lockscreen/LockScreen.qml (line 165)
<https://git.reviewboard.kde.org/r/124931/#comment58433>

    block.mainItem.model.get(block.mainItem.selectedIndex) ? !!block.mainItem.model.get(block.mainItem.selectedIndex).showPassword : false
    
    (Ideally we had a readonly property QtObject (var?) for that item somewhere)


- Kai Uwe Broulik


On Aug. 26, 2015, 10:42 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124931/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 10:42 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This fixes type errors shown on startup:
> TypeError: Cannot read property 'showPassword' of undefined
> TypeError: Cannot read property 'ButtonLabel' of undefined
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 
> 
> Diff: https://git.reviewboard.kde.org/r/124931/diff/
> 
> 
> Testing
> -------
> 
> run kscreenlocker_greet --testing. Error no longer shown, items's still working
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/b6ee72c3/attachment.html>


More information about the Plasma-devel mailing list