Review Request 124917: [screenlocker] Start grace time when the greeter is shown

Marco Martin notmart at gmail.com
Wed Aug 26 08:35:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124917/#review84396
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Aug. 25, 2015, 10:53 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124917/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> So far the grace time started with the idle timeout. Given that our
> greeter takes a few seconds to start it rendered a short grace time
> useless as it was quite likely that the grace time already ended when
> the first visible feedback was shown to the user.
> 
> Now the grace time starts when the greeter is actually shown.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/ksldapp.cpp d0636b8785101cb9896cea6399952dac0e4cd227 
> 
> Diff: https://git.reviewboard.kde.org/r/124917/diff/
> 
> 
> Testing
> -------
> 
> * grace time of 5 sec: waited for the lock screen to show, counted to 4, moved mouse -> unlocked
> * waited till the lock screen was shown and a few minutes more, moved mouse -> no unlock
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/0920f15d/attachment.html>


More information about the Plasma-devel mailing list