Review Request 124929: [screenlocker] Cleanup in LockWindow

Martin Gräßlin mgraesslin at kde.org
Wed Aug 26 05:55:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124929/
-----------------------------------------------------------

Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
-------

It set to arrow cursor which is the default anyway.

[screenlocker] Drop setting event mask on the background window

We don't need it as we get keyboard and pointer events anyway (grab),
exposure is set by Qt anyway and for everything else we have
substructure redirect on the root window.

Setting the background pixel is also no longer needed: we render a
black, non-translucent window.

[screenlocker] Rename LockWindow to X11Locker

The LockWindow is no longer a window, but it's the actual locker for
X11.


Diffs
-----

  ksmserver/screenlocker/autotests/lockwindowtest.cpp 7d8fe542b98ab19cf04554e179e63e238d34e09d 
  ksmserver/screenlocker/ksldapp.h 27c25df3bca7b30d78b1e4de34c437aa7ff33f59 
  ksmserver/screenlocker/ksldapp.cpp 83527045890eac4e2cbd84767db10da4279cc5b5 
  ksmserver/screenlocker/lockwindow.h dffaa729081cf3c6cff507f0a481e30666e2ddbc 
  ksmserver/screenlocker/lockwindow.cpp 41d54b3c5ffe67de4a09676e589effc4c564e470 

Diff: https://git.reviewboard.kde.org/r/124929/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150826/a8a1b87a/attachment.html>


More information about the Plasma-devel mailing list