Review Request 124869: Fix widget explorer sometimes opening on the wrong side of the screen.

David Edmundson david at davidedmundson.co.uk
Mon Aug 24 10:01:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124869/
-----------------------------------------------------------

(Updated Aug. 24, 2015, 10:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 544e98da26ffc6a71f9a0a8f1c38ce505cb930d1 by David Edmundson to branch Plasma/5.4.


Repository: plasma-desktop


Description
-------

Work around a Qt bug.

If there is no setGeometry call on QWindow the XCB backend will not pass
our requested position to kwin
as our window position tends to be 0, setX,setY no-ops and means we
never set a position as far as QWindow is concerned
by setting it to something silly and setting it back before we show the
window we avoid that bug.

Qt patch also filed (https://codereview.qt-project.org/123989)
so hopefully this can be removed in future if that gets merged.

BUG: 332702


Diffs
-----

  desktoppackage/contents/views/Desktop.qml e52108c7f2a4fd58a74642d09893c51fbf701f55 

Diff: https://git.reviewboard.kde.org/r/124869/diff/


Testing
-------

Had a billion lines of qDebug in kwin that shows it now gets a geometry in KWin::manage.

Also window is always in the right place \o/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150824/d7c03ed7/attachment.html>


More information about the Plasma-devel mailing list