Review Request 124885: Fix issues in translation control module
Jeremy Whiting
jpwhiting at kde.org
Sun Aug 23 01:47:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124885/#review84202
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On Aug. 22, 2015, 6:34 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124885/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2015, 6:34 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 345761 and 347956
> https://bugs.kde.org/show_bug.cgi?id=345761
> https://bugs.kde.org/show_bug.cgi?id=347956
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Fixes two problems:
> * Variants not being shown up, i.e. ca ca at valencia showing up both as "català"
> * pt showing up as "português do Brasil"
>
> For the first one i've went the easy route of adding the languageCode if there's an @ in it
> For pt i hard to hard code it since i found no other way to make Qt understand that for "pt" we mean portuguese from portugal
>
>
> Diffs
> -----
>
> kcms/translations/kcmtranslations.cpp e5024e2
>
> Diff: https://git.reviewboard.kde.org/r/124885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150823/28bd3d1d/attachment.html>
More information about the Plasma-devel
mailing list