Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

Takahiro Hashimoto kenya888 at gmail.com
Sat Aug 22 11:04:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/
-----------------------------------------------------------

Review request for Plasma.


Bugs: https://bugs.kde.org/show_bug.cgi?id=351609
    https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=351609


Repository: plasma-workspace


Description
-------

Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 generates corrupted files.

$HOME/.config/startupconfigfiles
$HOME/.config/startupconfig

Reproducible: Always

Steps to Reproduce:
1. Build KF5 with Qt5.6 latest branch
2. exec k(do)startupconfig
3. view your startupconfig files 

Actual Results:  
These files are corrupted (attached)

Expected Results:  
Generate these files correctly

The  root cause of  this  the change of QString::fromLocal8Bit(const QByteArray & str) behavior on Qt 5.6 branch by the following commit.

https://codereview.qt-project.org/#/c/96845/


Diffs
-----

  startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 

Diff: https://git.reviewboard.kde.org/r/124877/diff/


Testing
-------


Thanks,

Takahiro Hashimoto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150822/c1d51092/attachment-0001.html>


More information about the Plasma-devel mailing list